[Mesa-dev] [PATCH 2/3] Disable direct rendering on GNU/Hurd

[Jon TURNEY]

On 15/03/2011 00:28, Jakob Bornecrantz wrote:
> On Mon, Mar 14, 2011 at 11:08 PM, Jon TURNEY
> <jon.turney at dronecode.org.uk> wrote:
>> From: nobled <nobled at dreamwidth.org>
>>
>> The Hurd kernel doesn't have DRM yet.
>>
>> Signed-off-by: Jon TURNEY <jon.turney at dronecode.org.uk>
>> Reviewed-by: Julien Cristau <jcristau at debian.org>
>> ---
>>  configure.ac |   13 +++++++++++--
>>  1 files changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 38e673d..5bcb5a1 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -730,12 +730,21 @@ else
>>  fi
>>
>>  dnl Direct rendering or just indirect rendering
>> +case "$host_os" in
>> +gnu*)
>> +    dnl Disable by default on GNU/Hurd
>> +    driglx_direct_default="no"
>> +    ;;
>> +*)
>> +    driglx_direct_default="yes"
>> +    ;;
>> +esac
> 
> Isn't there somewhere else in the configure file where we setup
> defaults based on OS where this could go? Or is that to late?
> Otherwise looks good.

$ grep 'case "$host_os"' configure.ac | wc -l
11

The style seems to be to have separate checks of $host_os preceding each block
which needs to use some host-specific value, and this change conforms with
that style.