[Mesa-dev] [PATCH 28/41] i965: Resolve buffers before drawing

[Chad Versace]

On 11/18/2011 04:37 PM, Eric Anholt wrote:
> On Thu, 17 Nov 2011 19:58:55 -0800, Chad Versace <chad.versace at linux.intel.com> wrote:
>> Before emitting primitives in brw_try_draw_prims(), resolve the depth
>> buffer's HiZ buffer and resolve the depth buffer of each enabled depth
>> texture.
>>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>> ---
>>  src/mesa/drivers/dri/i965/brw_draw.c |   73 ++++++++++++++++++++++++++++++++++
>>  1 files changed, 73 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
>> index d2ae087..88e0194 100644
>> --- a/src/mesa/drivers/dri/i965/brw_draw.c
>> +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> 
>> @@ -316,6 +384,11 @@ static bool brw_try_draw_prims( struct gl_context *ctx,
>>      */
>>     brw_validate_textures( brw );
>>  
>> +   /* Resolves must occur after updating state and finalizing textures but
>> +    * before validating drm bo's.
>> +    */
>> +   brw_predraw_resolve_buffers(brw);
>> +
> 
> Validating drm BOs doesn't exist any more (hooray!), but I would still
> say "before setting up any hardware state for this draw call".

Right. That comment is stale. I replaced it verbatim with your suggestion:

   /* Resolves must occur after updating state and finalizing textures but
    * before setting up any hardware state for this draw call.
    */
   brw_predraw_resolve_buffers(brw);

----
Chad Versace
chad.versace at linux.intel.com