[Mesa-dev] [PATCH] mesa: re-implement unpacking of DEPTH_COMPONENT32F

[Eric Anholt]

On Tue, 22 Nov 2011 21:43:53 +0100, Marek Olšák <maraeo at gmail.com> wrote:
> On Tue, Nov 22, 2011 at 9:13 PM, Patrick Baggett
> <baggett.patrick at gmail.com> wrote:
> >
> >
> > On Tue, Nov 22, 2011 at 2:07 PM, Marek Olšák <maraeo at gmail.com> wrote:
> >>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=43122
> >> ---
> >>  src/mesa/main/format_unpack.c |   10 ++++++++++
> >>  1 files changed, 10 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
> >> index 6e2ce7a..52f224a 100644
> >> --- a/src/mesa/main/format_unpack.c
> >> +++ b/src/mesa/main/format_unpack.c
> >> @@ -1751,6 +1751,13 @@ unpack_float_z_Z32(GLuint n, const void *src,
> >> GLfloat *dst)
> >>  }
> >>
> >>  static void
> >> +unpack_float_z_Z32F(GLuint n, const void *src, GLfloat *dst)
> >> +{
> >> +   const GLfloat *s = ((const GLfloat *) src);
> >> +   memcpy(dst, s, n * sizeof(float));
> >> +}
> >
> > Why bother typecasting here in a separate variable 's'?
> 
> That's a copy-paste typo. I'll remove it.

Thanks.  With that fixed,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111122/e6999a0e/attachment.pgp>