[Mesa-dev] [PATCH] i965: Make gen6_resolve_implied_move a no-op for MRF sources.

Kenneth Graunke kenneth at whitecape.org
Mon Nov 28 20:21:45 PST 2011


Attempting to move an MRF to a MRF is not only pointless, it will fail
because MRFs are read-only, resulting in garbage in your register.

If we already set up a MRF source, there's nothing to resolve anyway.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_eu_emit.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

I could've sworn I sent this out a week and a half ago, but I don't remember
getting any responses and can't seem to find it in my mail archive.  Oops.

diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c
index 60350ca..9d8c701 100644
--- a/src/mesa/drivers/dri/i965/brw_eu_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_eu_emit.c
@@ -67,6 +67,9 @@ gen6_resolve_implied_move(struct brw_compile *p,
    if (intel->gen < 6)
       return;
 
+   if (src->file == BRW_MESSAGE_REGISTER_FILE)
+      return;
+
    if (src->file != BRW_ARCHITECTURE_REGISTER_FILE || src->nr != BRW_ARF_NULL) {
       brw_push_insn_state(p);
       brw_set_mask_control(p, BRW_MASK_DISABLE);
-- 
1.7.7.3



More information about the mesa-dev mailing list