[Mesa-dev] [PATCH] winsys: fill in missing displaytarget bits in null winsys
fredrik at kde.org
Wed Oct 5 12:09:56 PDT 2011
On Wednesday 05 October 2011, Jose Fonseca wrote:
> ----- Original Message -----
> > This is needed for renderbuffer support.
> What state tracker relies on this?
The EGL state tracker relies on it for user-created renderbuffers in
the recently added null platform.
st_renderbuffer_alloc_storage() always creates color buffer resources
with PIPE_BIND_DISPLAY_TARGET, and this causes llvmpipe_resource_create()
to call into this code to allocate storage.
> I don't object this change, but it sounds like you should be using a proper sw winsys, instead of null winsys. The null winsys can't really display anything, so the current implementation is more honest.
I agree with what you're saying, and having thought about this some
more I believe a better solution is to identify user-created renderbuffers
in st_renderbuffer_alloc_storage() instead of specifying
I have attached a new patch that does that.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1765 bytes
Desc: not available
More information about the mesa-dev