[Mesa-dev] [PATCH] mesa: fix glTexSubImage bugs in compressed texture code

[Eric Anholt]

On Wed,  5 Oct 2011 20:57:24 -0600, Brian Paul <brian.e.paul at gmail.com> wrote:
> From: Brian Paul <brianp at vmware.com>
> 
> This fixes failures found with the new piglit texsubimage test.
> 
> Two things were broken:
> 1. The dxt code doesn't handle sources images where width != row stride.
>    Check for that and take the _mesa_make_temp_ubyte_image() path to get
>    an image where width = rowstride.
> 2. If we don't take the _mesa_make_temp_ubyte_image() path we need to
>    take the source image unpacking parameters into account in order to
>    get the proper starting memory address of the source texels.

Perhaps call it "fix compressed glTexSubImage for with non-default
unpack params"?  It looked like two separate patches until I realized
both were about unpack twiddling.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111006/55aa9716/attachment.pgp>