[Mesa-dev] [PATCH 1/2] i965: Split brw_set_prim into brw/gen6 variants

Eric Anholt eric at anholt.net
Mon Oct 10 10:53:56 PDT 2011


On Fri,  7 Oct 2011 10:16:47 -0700, Chad Versace <chad at chad-versace.us> wrote:
> The "slight optimization to avoid the GS program" in brw_set_prim() is not
> used by Gen 6, since Gen 6 doesn't use a GS program. Also, Gen 6 doesn't use
> reduced primitives.
> 
> Also, document that intel_context.reduced_primitive is only used for Gen < 6
> 
> Signed-off-by: Chad Versace <chad at chad-versace.us>

> diff --git a/src/mesa/drivers/dri/intel/intel_context.h b/src/mesa/drivers/dri/intel/intel_context.h
> index eb78c00..cf7ab9e 100644
> --- a/src/mesa/drivers/dri/intel/intel_context.h
> +++ b/src/mesa/drivers/dri/intel/intel_context.h
> @@ -253,7 +253,7 @@ struct intel_context
>     GLuint RenderIndex;
>     GLmatrix ViewportMatrix;
>     GLenum render_primitive;
> -   GLenum reduced_primitive;
> +   GLenum reduced_primitive; /*< Only gen < 6 */

If this is intended to be doxygen, that would be /**< whatever */

Other than that, Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111010/c5a670f1/attachment.pgp>


More information about the mesa-dev mailing list