[Mesa-dev] mesa,swrast,vbo,meta: Prepare for HiZ on i965

Chad Versace chad at chad-versace.us
Tue Oct 18 11:19:25 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2011 08:19 AM, Brian Paul wrote:
> On 10/17/2011 08:27 AM, Chad Versace wrote:
>> HiZ is near completion on i965, and it requires some preliminary changes to
>> core Mesa. No big changes here; a quick bugfix, redeclaring functions as
>> non-static, and adding an extra meta-op flag and some functions to the Driver
>> vtbl.
> 
> The core Mesa stuff looks good to me.
> 
> One minor nit: in patch 5/6 put a space after your ifs: 'if(x)' -> 'if (x)'
> 
> Reviewed-by: Brian Paul <brianp at vmware.com>

Oops. I'll fix the missing space; that was accidental.

I'm also going to remove the CleanupExecEnd hook in 5/6. Anholt and I discussed it
and discovered that it was unneeded.

Thanks for the review.

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIbBAEBAgAGBQJOncMrAAoJEAIvNt057x8iqM0P93H9Cpl8xXfI9wbxhNd4RH9U
7VSxbScF670nkOnZC8GRuehDo4SnN7/4U+xZxXg8QVVIkgFDSajtcFDjtha/0EE4
L3KhDwH+Plog7STO51ad/YprYT9Qudw/nWn/DpE2eKW5R4JuOPJzoLEbRnv90BaC
CEntt36vFGcxVIeblupwhG1iwavl/u5Jq2VTsDH3kZtAGk0ZKiJeZQTOXH2bZdKk
292n32bteC8UWyW/WjklbWU5EcWcRFDd0nt4pVdlWx2/JHXRsFbbrdfpc9xHer+i
krapXYj1jPn+OnxnIEOGdNCt2fo7VfCLHBX5pHwERhDeFkM+Ki+R9DzodMJBz+FZ
g8BRl792q4H0Z/I80KQbrY8A0R6unDMuO8o+Ynl1nI8Ze5UWCOiGyYD7tpdEmBwo
sugHH9aB/uAoVpOwyiBVuFn+ny+D5WF1fswvZ4aQsh9vxG0tR/bzXurN/yPZ6AIb
WrRP8YxKBdA1PtZY75y9bCSLEj6xYGGL7z5OFPA8iTnhc/PgNp0FgAZfZApHFTvK
AfgqrDAXT+hYUvbYquAaT5LUDqTCsNIo1NQX8XePzGSi0dVMJ9mRd4rmuffJRYbN
Cf45bI68I/hVNoCIyS7ZAGzWtV6d8g0vGwdVMjdWV/kywN3oZu7zZnR9mk6+lyes
GZ93PIBqDUdfAE8VZrc=
=IkAz
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list