[Mesa-dev] [PATCH v2 2/8] glsl: Distinguish between no interpolation qualifier and 'smooth'
kenneth at whitecape.org
Wed Oct 26 12:14:16 PDT 2011
On 10/25/2011 08:38 PM, Paul Berry wrote:
> Previously, we treated the 'smooth' qualifier as equivalent to no
> qualifier at all. However, this is incorrect for the built-in color
> variables (gl_FrontColor, gl_BackColor, gl_FrontSecondaryColor, and
> gl_BackSecondaryColor). For those variables, if there is no qualifier
> at all, interpolation should be flat if the shade model is GL_FLAT,
> and smooth if the shade model is GL_SMOOTH.
> To make this possible, I added a new value to the
> glsl_interp_qualifier enum, INTERP_QUALIFIER_NONE.
Patches 2 and 3 look good as well. So does patch 7. Consider those
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
I'm getting a little lost reading through the rest of the i965 code, but
I'll try get through that today.
More information about the mesa-dev