[Mesa-dev] [PATCH 1/7] mesa: Add GL_OES_compressed_paletted_texture formats to _mesa_is_compressed_format

Brian Paul brianp at vmware.com
Wed Sep 14 07:04:04 PDT 2011


On 09/13/2011 04:40 PM, Ian Romanick wrote:
> From: Ian Romanick<ian.d.romanick at intel.com>
>
> Signed-off-by: Ian Romanick<ian.d.romanick at intel.com>
> ---
>   src/mesa/main/image.c |   13 +++++++++++++
>   1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/main/image.c b/src/mesa/main/image.c
> index 3e75e7c..da8eaff 100644
> --- a/src/mesa/main/image.c
> +++ b/src/mesa/main/image.c
> @@ -1068,6 +1068,19 @@ _mesa_is_compressed_format(struct gl_context *ctx, GLenum format)
>         return ctx->Extensions.EXT_texture_compression_latc;
>      case GL_COMPRESSED_LUMINANCE_ALPHA_3DC_ATI:
>         return ctx->Extensions.ATI_texture_compression_3dc;
> +#if FEATURE_ES
> +   case GL_PALETTE4_RGB8_OES:
> +   case GL_PALETTE4_RGBA8_OES:
> +   case GL_PALETTE4_R5_G6_B5_OES:
> +   case GL_PALETTE4_RGBA4_OES:
> +   case GL_PALETTE4_RGB5_A1_OES:
> +   case GL_PALETTE8_RGB8_OES:
> +   case GL_PALETTE8_RGBA8_OES:
> +   case GL_PALETTE8_R5_G6_B5_OES:
> +   case GL_PALETTE8_RGBA4_OES:
> +   case GL_PALETTE8_RGB5_A1_OES:
> +      return ctx->API == API_OPENGLES;
> +#endif
>      default:
>         return GL_FALSE;
>      }

For the series:  Reviewed-by: Brian Paul <brianp at vmware.com>

The only thing I might add is some extra comments explaining the goofy 
usage of negative 'level' values.   I had to go read the spec to find 
out what that was all about.

-Brian


More information about the mesa-dev mailing list