[Mesa-dev] [PATCH] mesa: Fix save/restore of ActiveProgram in meta-ops

Eric Anholt eric at anholt.net
Wed Sep 21 09:57:48 PDT 2011


On Tue, 20 Sep 2011 12:01:56 -0700, Chad Versace <chad at chad-versace.us> wrote:
> The mismatch below caused ActiveProgram to be incorrectly saved/restored:
> 
>     _meas_meta_begin:
>         line 465) ActiveShader := gl_shader_state::CurrentFragmentProgram
>     _mesa_meta_end:
>         line 741) gl_shader_state::ActiveProgram := ActiveShader
> 
> This patch fixes it to be:
> 
>     _meas_meta_begin:
>         line 465) ActiveShader := gl_shader_state::ActiveProgram
>     _mesa_meta_end:
>         line 741) gl_shader_state::ActiveProgram := ActiveShader
> 
> I discovered this bug by inspection.

Quite a commit message for a copy and paste fix (and includes a typo
"meas_meta_begin :) ) The patch looks obviously correct.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110921/25119de6/attachment.pgp>


More information about the mesa-dev mailing list