[Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

[Paul Berry]

On 20 September 2011 18:28, Kenneth Graunke <kenneth at whitecape.org> wrote:

> diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp
> index d6594cd..70d0ae2 100644
> --- a/src/glsl/ir.cpp
> +++ b/src/glsl/ir.cpp
> @@ -725,6 +725,15 @@ ir_constant::zero(void *mem_ctx, const glsl_type
> *type)
>    return c;
>  }
>
> +ir_constant *
> +ir_constant::error_value(void *ctx)
> +{
> +   ir_constant *ir = new(ctx) ir_constant;
> +
> +   ir->type = glsl_type::error_type;
> +   return ir;
> +}
> +
>  bool
>  ir_constant::get_bool_component(unsigned i) const
>  {
> @@ -1446,16 +1455,6 @@ ir_function::has_user_signature()
>    return false;
>  }
>
> -
> -ir_call *
> -ir_call::get_error_instruction(void *ctx)
> -{
> -   ir_call *call = new(ctx) ir_call;
> -
> -   call->type = glsl_type::error_type;
> -   return call;
> -}
> -
>

I believe this was the only code that used the private constructor
ir_call::ir_call() (the one that took no parameters), so we should probably
remove that too.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110921/62f2de80/attachment.htm>