[Mesa-dev] Intel TexImage cleanup

Kenneth Graunke kenneth at whitecape.org
Thu Sep 22 16:55:22 PDT 2011


On 09/22/2011 12:34 PM, Eric Anholt wrote:
> Only 75 lines of code deletion to offer here.
> 
> My goal was to delete the whole CPU upload part of intelTexImage by
> moving the mt setup to AllocTextureImageBuffer and using the
> MapTextureImage-based Mesa core.  However, because we don't have all
> of core converted to MapTextureImage, there are places that call
> AllocTextureImageBuffer then immediately expect ->Data to be present,
> which we wouldn't be able to provide.

This looks good to me, but I'm not at all well versed in this.

1, 2, 6, 7 are
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(though, in 7 your commit message says "consumers consumers")

the rest are
Acked-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list