[Mesa-dev] [PATCH] intel: fix potential segfault error at intel_(un)map_texture_image

Eric Anholt eric at anholt.net
Fri Sep 23 10:06:52 PDT 2011


On Thu, 15 Sep 2011 16:02:49 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> intel_image->mt might be NULL, say with border width set. It then would
> trigger a segfault at intel_map/unmap_texture_image function.
> 
> This would fix the oglc misctest(basic.textureBorderIgnore) fail.
> 
> Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>

Oops, never saw this, and sent a version of it out yesterday myself.

You shouldn't need the ->region check, since we shouldn't ever have a
miptree without one.  Other than that, go ahead and push.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110923/cb632f29/attachment.pgp>


More information about the mesa-dev mailing list