[Mesa-dev] [PATCH 1/4] gallium: add polygon offset clamp state

Christoph Bumiller e0425955 at student.tuwien.ac.at
Mon Sep 26 14:11:19 PDT 2011


On 25.09.2011 00:32, Brian Paul wrote:
> On Sat, Sep 24, 2011 at 7:47 AM, Christoph Bumiller
> <e0425955 at student.tuwien.ac.at> wrote:
>> This is required for D3D1x and supported by hardware.
>> ---
>>  src/gallium/auxiliary/draw/draw_pipe_offset.c |    6 ++++++
>>  src/gallium/auxiliary/util/u_dump_state.c     |    1 +
>>  src/gallium/docs/source/cso/rasterizer.rst    |    2 ++
>>  src/gallium/drivers/trace/tr_dump_state.c     |    1 +
>>  src/gallium/include/pipe/p_state.h            |    1 +
>>  5 files changed, 11 insertions(+), 0 deletions(-)
> Looks OK to me.  If this is ever exposed as an OpenGL extension we'll
> probably want a new PIPE_CAP_ flag to indicate if the driver supports
> it.
>
> -Brian
>

Thanks for the review.
So I'll probably push this in a day or two if no one objects, and it
sounds like you're OK with deferring the addition of a
PIPE_CAP_POLYGON_OFFSET_CLAMP until some API or extension will want to
query it (which might never happen, D3D10+ just assum you can do it).



More information about the mesa-dev mailing list