[Mesa-dev] [PATCH 6/8] build: Fix autogen.sh to allow out-of-tree builds

Matt Turner mattst88 at gmail.com
Wed Aug 1 15:51:17 PDT 2012


On Wed, Aug 1, 2012 at 3:48 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On 08/01/2012 03:02 PM, Matt Turner wrote:
>> ---
>> Still some buggy areas, including Gallium and GLES.
>>
>>  autogen.sh |   12 +++---------
>>  1 files changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/autogen.sh b/autogen.sh
>> index b5f6ec4..3e6e500 100755
>> --- a/autogen.sh
>> +++ b/autogen.sh
>> @@ -1,19 +1,13 @@
>>  #! /bin/sh
>>
>> -srcdir=`dirname "$0"`
>> +srcdir=`dirname $0`
>
> It's not clear to me why you would need to remove the quotes.  It
> probably only matters if your mesa source directory has a path with
> spaces in it (which may or may not work - I haven't tried), but...I'd be
> inclined to leave it if it isn't necessary.
>
> Otherwise, looks fine.

Not really any reason. I copied it from xf86-video-intel. I'll add the
quotes back since I don't think they can hurt anything.


More information about the mesa-dev mailing list