[Mesa-dev] [PATCH] llvmpipe: remove unneeded draw_flush() call

Jose Fonseca jfonseca at vmware.com
Wed Dec 12 07:42:10 PST 2012


Sounds good to me.

Jose

----- Original Message -----
> This is redundant since we're calling draw_bind_fragment_shader()
> which already does a flush.
> 
> v2: the redundant flush in llvmpipe_set_constant_buffer() has
> already been removed by commit
> 3427466e6dbbb8db7c1ecda6b3859ca1cc5827a3
> ---
>  src/gallium/drivers/llvmpipe/lp_state_fs.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_state_fs.c
> b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> index bf59a43..5a8351b 100644
> --- a/src/gallium/drivers/llvmpipe/lp_state_fs.c
> +++ b/src/gallium/drivers/llvmpipe/lp_state_fs.c
> @@ -2312,8 +2312,6 @@ llvmpipe_bind_fs_state(struct pipe_context
> *pipe, void *fs)
>     if (llvmpipe->fs == fs)
>        return;
>  
> -   draw_flush(llvmpipe->draw);
> -
>     llvmpipe->fs = (struct lp_fragment_shader *) fs;
>  
>     draw_bind_fragment_shader(llvmpipe->draw,
> --
> 1.7.3.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


More information about the mesa-dev mailing list