[Mesa-dev] [PATCH 2/4] Update comment to specify actual text being referenced from the specification.

[Ian Romanick]

On 12/17/2012 02:24 PM, Carl Worth wrote:

Patches 2 and 3 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

There doesn't appear to be an order dependency with the other patches in 
the series.  Perhaps these should go in first?

> The reference to "correct, see spec" was a bit too vague to be useful,
> (particularly since the language being referenced here changes between OpenGL
> 3.1 and OpenGL 4.3).
> ---
>   src/mesa/main/queryobj.c |    7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
> index aa7c800..b482b15 100644
> --- a/src/mesa/main/queryobj.c
> +++ b/src/mesa/main/queryobj.c
> @@ -50,7 +50,12 @@ _mesa_new_query_object(struct gl_context *ctx, GLuint id)
>         q->Id = id;
>         q->Result = 0;
>         q->Active = GL_FALSE;
> -      q->Ready = GL_TRUE;   /* correct, see spec */
> +
> +      /* This is to satisfy the language of the specification: "In the initial
> +       * state of a query object, the result is available" (OpenGL 3.1 §
> +       * 2.13).
> +       */
> +      q->Ready = GL_TRUE;
>      }
>      return q;
>   }
>