[Mesa-dev] [PATCH 3/5] glsl: Plumb through is_parameter to apply_type_qualifier_to_variable()

[Paul Berry]

On 19 December 2012 09:13, Matt Turner <mattst88 at gmail.com> wrote:

> On Wed, Dec 19, 2012 at 8:42 AM, Paul Berry <stereotype441 at gmail.com>
> wrote:
> > This patch adds logic to allow the ast_to_hir function
> > apply_type_qualifier_to_variable() to tell whether it is acting on a
> > variable declaration or a function parameter.  This will allow it to
> > correctly interpret the meaning of "out" and "in" keywords (which have
> > different meanings in those two contexts).
> > ---
> >  src/glsl/ast_to_hir.cpp | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> > index 94b63f6..a14fe7d 100644
> > --- a/src/glsl/ast_to_hir.cpp
> > +++ b/src/glsl/ast_to_hir.cpp
> > @@ -1915,7 +1915,8 @@ apply_type_qualifier_to_variable(const struct
> ast_type_qualifier *qual,
> >                                  ir_variable *var,
> >                                  struct _mesa_glsl_parse_state *state,
> >                                  YYLTYPE *loc,
> > -                                bool ubo_qualifiers_valid)
> > +                                bool ubo_qualifiers_valid,
> > +                                 bool is_parameter)
>
> Whitespace might be a little off here.
>

It's actually fine--this is another case of the old "tabs vs spaces look
different in diffs" problem.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20121219/2caa1fea/attachment.html>