[Mesa-dev] [PATCH 3/4] queryobj: Add IsQuery flag, making ISQuery() return false before BeginQuery()

[Matt Turner]

On Mon, Dec 17, 2012 at 2:24 PM, Carl Worth <cworth at cworth.org> wrote:
> +      /* OpenGL 3.1 § 2.13 says about GenQueries, "These names are marked as
> +       * used, but no object is associated with them until the first time they
> +       * are used by BeginQuery." Since our implementation actually does
> +       * allocate an object at this point, use a flag to indicate that this
> +       * object is not (yet) a query.
> +       */
> +      q->IsQuery = GL_FALSE;

The 4.2 and 4.3 specs say

... but no object is associated with them until the first time they
are used by BeginQuery, BeginQueryIndexed, or QueryCounter.

BeginQuery vs BeginQueryIndexed are no problem, since _mesa_BeginQuery
internally is implemented with the -Indexed version. Is the
QueryCounter change actually a change in behavior or should be be
implementing that now too?