[Mesa-dev] [PATCH] mesa: Add unpack_uint_z_row support for floating-point depth buffers

Ian Romanick idr at freedesktop.org
Thu Feb 2 08:33:55 PST 2012


On 02/02/2012 06:41 AM, Henri Verbeet wrote:
> On 1 February 2012 23:12, Brian Paul<brianp at vmware.com>  wrote:
>>> +static void
>>> +unpack_uint_z_Z32_FLOAT(const void *src, GLuint *dst, GLuint n)
>>> +{
>>> +   const float *s = ((const float *)src);
>>
>>
>> More parens than necessary there.
>>
> The entire cast is unnecessary, IMO. But of course that would apply to
> the other functions in that file as well.

Right.  This was a copy-and-paste of another Z32_FLOAT function.  I'm 
not too worried about the cosmetics of this code.  I'm planning to 
convert a bunch of these mechanical things over to generated code for 
8.1.  Each copy-and-paste bug that I find (see my recent patches) 
reinforces my desire to do that conversion. :)


More information about the mesa-dev mailing list