[Mesa-dev] [PATCH 3/5] gallivm: add uint/int bld to the base builder.

[Dave Airlie]

On Mon, Feb 6, 2012 at 7:36 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
>
>
> ----- Original Message -----
>> From: Dave Airlie <airlied at redhat.com>
>>
>> These are used inside the action handlers for the integer opcodes.
>>
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>> ---
>>  src/gallium/auxiliary/gallivm/lp_bld_tgsi.h     |    3 +++
>>  src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c |    2 ++
>>  src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c |    2 ++
>>  3 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.h
>> b/src/gallium/auxiliary/gallivm/lp_bld_tgsi.h
>> index b03eefc..a320d94 100644
>> --- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.h
>> +++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi.h
>> @@ -279,6 +279,9 @@ struct lp_build_tgsi_context
>>  {
>>     struct lp_build_context base;
>>
>> +   struct lp_build_context uintbld;
>> +   struct lp_build_context intbld;
>
> Looks good, but please name these int_bld, uint_bld, so it's consistent with other gallivm modules.
>

I actually didn't name that on purpose, since the layer above uses
those names and I thought it would stop people easily using the wrong
one in the wrong place,

though I expect I should probably try and get rid of the upper layer
ones and use these instead.

Dave.