[Mesa-dev] [PATCH 1/2] i965: Report the failure message when failing to compile the fragment shader.

nobled nobled at dreamwidth.org
Sun Feb 12 05:49:59 PST 2012


On Fri, Feb 10, 2012 at 12:42 AM, Eric Anholt <eric at anholt.net> wrote:
> We just abort later, but at least this should result in more
> informative bug reports.
> ---
>  src/mesa/drivers/dri/i965/brw_fs.cpp |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 6ecaa6c..bf59da3 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -1844,6 +1844,9 @@ brw_wm_fs_emit(struct brw_context *brw, struct brw_wm_compile *c,
>       prog->LinkStatus = false;
>       ralloc_strcat(&prog->InfoLog, v.fail_msg);
>
> +      _mesa_problem(NULL, "Failed to compile fragment shader: %s\n",
We should pass &brw->intel.ctx here instead of null, right?
> +                   v.fail_msg);
> +
>       return false;
>    }
>
> --
> 1.7.9
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list