[Mesa-dev] [PATCH] glapi: Fix incorrect enum value.

Paul Berry stereotype441 at gmail.com
Wed Feb 22 16:25:53 PST 2012


On 22 February 2012 14:22, Ian Romanick <idr at freedesktop.org> wrote:

> On 02/22/2012 02:17 PM, Paul Berry wrote:
>
>> On 22 February 2012 13:52, Ian Romanick <idr at freedesktop.org
>> <mailto:idr at freedesktop.org>> wrote:
>>
>>    On 02/22/2012 01:41 PM, Paul Berry wrote:
>>
>>          From
>>        http://www.opengl.org/__**registry/specs/ARB/seamless___**
>> cube_map.txt<http://www.opengl.org/__registry/specs/ARB/seamless___cube_map.txt>
>>
>>        <http://www.opengl.org/**registry/specs/ARB/seamless_**
>> cube_map.txt<http://www.opengl.org/registry/specs/ARB/seamless_cube_map.txt>
>> >:
>>
>>             Accepted by the<cap>  parameter of Enable, Disable and
>>        IsEnabled,
>>             and by the<pname>  parameter of GetBooleanv, GetIntegerv,
>>        GetFloatv
>>             and GetDoublev:
>>
>>             TEXTURE_CUBE_MAP_SEAMLESS                   0x884F
>>
>>
>>    Oops.  That was my typo.  You'll also have to regenerate the various
>>    files that depend on the XML definitions.  I think this change
>>    should only cause changes in src/mesa/main/enums.c.
>>
>>    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com
>>    <mailto:ian.d.romanick at intel.**com <ian.d.romanick at intel.com>>>
>>
>>
>>
>> Oops.  I didn't realize that those files weren't built automatically.
>> I'll send an updated patch.
>>
>
> Dear god, no!  The patch will be huge.


Actually, it's pretty tiny since it didn't change any enum names (and hence
didn't move around the offsets in all_enums).  But I can see why the patch
would be huge in most cases.  All the same, the diff is not very
informative, so I will spare you having to look at it :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120222/79bed408/attachment-0001.htm>


More information about the mesa-dev mailing list