[Mesa-dev] [PATCH 04/10] mesa: Adds parameter to drive varyings packing

Brian Paul brian.e.paul at gmail.com
Thu Feb 23 12:49:43 PST 2012


On Thu, Feb 23, 2012 at 3:12 PM, Vincent Lejeune <vljn at ovi.com> wrote:
> ---
>  src/mesa/main/mtypes.h    |   10 ++++++++++
>  src/mesa/main/shaderapi.c |    1 +
>  2 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 9200f3f..447d432 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -2392,6 +2392,14 @@ struct gl_shader_state
>    GLbitfield Flags;                    /**< Mask of GLSL_x flags */
>  };
>
> +enum packing_constraint
> +{
> +   NONE, /** no limitation (scalar architecture : swrast, nouveau) */
> +   SMOOTH_NOPERSPECTIVE_MIXED, /** Smooth and noperspective varying can be mixed but not with flat (i965) */
> +   NO_MIXED_INTERPOLATION, /** Dont mix different interpolation (r300 and r600) */
> +   AVOID_PACKING, /** Disable packing */
> +};

These enum values should have a common prefix like
"PACKING_CONSTRAINT_" like we do for other enums.  See
FRAG_DEPTH_LAYOUT, for example.

And Doxygen comments after an item should start with /**<

-Brian


More information about the mesa-dev mailing list