[Mesa-dev] [PATCH 1/2] r300g: Reorganize the compiler unit tests

Ian Romanick idr at freedesktop.org
Mon Feb 27 13:16:20 PST 2012

On 02/27/2012 10:42 AM, Tom Stellard wrote:
> On Mon, Feb 27, 2012 at 09:51:02AM -0800, Ian Romanick wrote:
>> On 02/25/2012 08:08 AM, Tom Stellard wrote:
>> If these were moved up to, say, tests/r300 at the top level and put
>> in 'make test' I (and presumably others) would run them before
>> pushing. That might prevent some accidental breakages of your
>> driver. :)  If they were (eventually) converted to the gtest
>> framework, it would be even better.
> These tests are unit tests for some helper functions in the r300
> compiler, so it's not possible to break them unless you are working on
> the r300 compiler.

Ah, okay.  I hadn't looked at the tests, but I guessed (incorrectly) 
that they verified some code translation paths.

> Is gtest(googletest?) the testing framework of choice for Mesa?
> I've always wanted to add more tests and use a real testing framework,
> so if other components use gtest, I can try to use it too (assuming I
> ever get around to writing more tests).

It's the one I chose for the GLX_ARB_create_context unit tests that I 
wrote.  Unless someone suggests something better, I intend to continue 
using it.

More information about the mesa-dev mailing list