[Mesa-dev] [PATCH 02/11] i965: Add missing BRW_NEW_BATCH dirty bit to Gen6+ clip state atoms.
kenneth at whitecape.org
Mon Jan 9 12:09:35 PST 2012
On 01/09/2012 08:24 AM, Eric Anholt wrote:
> On Sun, 8 Jan 2012 14:43:51 -0800, Kenneth Graunke<kenneth at whitecape.org> wrote:
>> Without MI_SET_CONTEXT, there's no guarantee that another program hasn't
>> reprogram the GPU's clip state since our last batch. We need to submit
>> it every time.
>> Found by inspection.
> BRW_NEW_CONTEXT is the flag for "we might have lost our context because
> everything got reprogrammed."
> BRW_NEW_BATCH is the flag for "we have to program it again with a new
> batch for other reasons (e.g. relocations ensuring that your buffer is
> The intent was that when we get MI_SET_CONTEXT, we just stop flagging
> BRW_NEW_CONTEXT per batch.
Oh...thanks. Somehow I forgot that we currently flag BRW_NEW_CONTEXT on
every batch. I was thinking it was once, at the start of the program,
which would only work if we had MI_SET_CONTEXT.
I agree, these aren't necessary.
More information about the mesa-dev