[Mesa-dev] glsl optimizations infinite loop patch

Eric Anholt eric at anholt.net
Mon Jan 9 13:17:10 PST 2012


On Thu,  5 Jan 2012 21:17:52 -0600, Andy Clayton <q3aiml at gmail.com> wrote:
> Hi all,
> 
> So this is my attempt at a fix for
> https://bugs.freedesktop.org/show_bug.cgi?id=34006. Any feedback on if
> this looks right to anyone is much appreciated. Sven Arvidsson did
> confirm on bugzilla that the patch does not cause any piglit
> regressions and does also fix the infinite loop issue for him.

I'm so sorry this languished for so long -- I don't see bugzilla mails
in my inbox, and it wasn't part of the driver, so I never saw the bug
report.

I've added more details to the commit message and pushed your patch --
it was definitely a good improvement over what was there before.  I
think the more serious problem is that we do copy propagation for the R0
to R0 assignemnt in general -- I think we're going to have actual
rendering bugs from that once I cook up a testcase.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120109/2a2199ae/attachment.pgp>


More information about the mesa-dev mailing list