[Mesa-dev] [PATCH 00/14] Fix some linker stuff, kill one more user of ir_to_mesa
kenneth at whitecape.org
Tue Jan 10 00:14:05 PST 2012
On 01/06/2012 04:49 PM, Ian Romanick wrote:
> Patches 01/14 through 03/14 was previously sent to the list. It
> tickled a pre-existing bug (fixed by patch recently posted to the list
> by Eric) on some Intel chipsets.
> Patches 04/14 through 07/14 make the linker do some sampler tracking
> that was previously done by ir_to_mesa. I suspect that the same work
> is duplicated by st_glsl_to_tgsi, so some refactoring could probably
> happen there.
> The remaining patches gut the pre-compile paths and the use of
> ir_to_mesa from the i965 driver. There are a couple state bits that
> were previously calculated by ir_to_mesa that now must be tracked by
> the driver (see patches 12/14 and 14/14). It is arguable that these
> two patches should be squashed into 13/14. I sent them separately to
> make the changes more explicit.
> I observe no piglit regressions on SNB with this series. I don't have
> convenient access to other hardware, so I haven't tested that yet. I
> plan to do that testing before pushing.
If it's helpful, Dylan has G33, Pineview, G965, and GM45 set up in the
lab and running tests. You just drop in your git remote URL and branch
name and it runs Piglit on all your platforms. (No Ironlake or
Sandybridge yet, unfortunately...we need to buy more machines.)
Patches 1, 3, and 13 are
Acked-by: Kenneth Graunke <kenneth at whitecape.org>
Patches 2, 4-7, and 11 are
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
I am reluctant about 8-10 (replied separately); I also think 12 and 14
could be done better but if there isn't time, then oh well.
More information about the mesa-dev