[Mesa-dev] [PATCH 1/5] meta: Add GL_RED/GL_RG support to meta CopyTexImage.

Brian Paul brianp at vmware.com
Wed Jan 11 14:52:41 PST 2012


On 01/11/2012 03:46 PM, Eric Anholt wrote:
> Fixes some _mesa_problem()s in oglconform.
> ---
>   src/mesa/drivers/common/meta.c |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
> index ad289aa..e4aced4 100644
> --- a/src/mesa/drivers/common/meta.c
> +++ b/src/mesa/drivers/common/meta.c
> @@ -3071,6 +3071,8 @@ get_temp_image_type(struct gl_context *ctx, GLenum baseFormat)
>      switch (baseFormat) {
>      case GL_RGBA:
>      case GL_RGB:
> +   case GL_RG:
> +   case GL_RED:
>      case GL_ALPHA:
>      case GL_LUMINANCE:
>      case GL_LUMINANCE_ALPHA:
> @@ -3086,7 +3088,8 @@ get_temp_image_type(struct gl_context *ctx, GLenum baseFormat)
>      case GL_DEPTH_STENCIL:
>         return GL_UNSIGNED_INT_24_8;
>      default:
> -      _mesa_problem(ctx, "Unexpected format in get_temp_image_type()");
> +      _mesa_problem(ctx, "Unexpected format %d in get_temp_image_type()",
> +		    baseFormat);
>         return 0;
>      }
>   }

The series looks good to me.

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list