[Mesa-dev] [PATCH 2/4] intel: Drop the version override code now that we don't have any left.

Kenneth Graunke kenneth at whitecape.org
Fri Jan 13 11:00:02 PST 2012


On 01/12/2012 04:48 PM, Eric Anholt wrote:
> On Thu, 12 Jan 2012 16:21:59 -0800, Kenneth Graunke<kenneth at whitecape.org>  wrote:
>> On 01/12/2012 04:08 PM, Eric Anholt wrote:
>>> Fixes a compiler warning.
>>> ---
>>>    src/mesa/drivers/dri/intel/intel_extensions.c |    8 --------
>>>    1 files changed, 0 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c
>>> index 7aa040c..0ce452f 100644
>>> --- a/src/mesa/drivers/dri/intel/intel_extensions.c
>>> +++ b/src/mesa/drivers/dri/intel/intel_extensions.c
>>> @@ -41,14 +41,6 @@ void
>>>    intelInitExtensions(struct gl_context *ctx)
>>>    {
>>>       struct intel_context *intel = intel_context(ctx);
>>> -   char *override = getenv("MESA_GL_VERSION_OVERRIDE");
>>> -   int override_major, override_minor;
>>> -   int override_version = 0;
>>> -
>>> -   if (override&&
>>> -       sscanf(override, "%u.%u",&override_major,&override_minor) == 2) {
>>> -      override_version = override_major * 10 + override_minor;
>>> -   }
>>>
>>>       ctx->Extensions.ARB_draw_elements_base_vertex = true;
>>>       ctx->Extensions.ARB_explicit_attrib_location = true;
>>
>> I would rather keep this...it seems like it will continue to be useful
>> as we move on to implementing 3.1, 3.2, 4.0, and so on.  There's not
>> really a lot gained by removing it, either...
>
> git log intel_extensions will find it quickly, and otherwise I'll be
> seeing this error every compile for the next 3 months.

Point taken.

For some reason I was thinking this was the Core mesa code.  But it's 
obviously not.  I'm okay with dropping this.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list