[Mesa-dev] renderbuffer-cleanups-v2 branch

[Brian Paul]

On Mon, Jan 16, 2012 at 4:31 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 01/16/2012 01:30 PM, Brian Paul wrote:
>>
>>
>> The renderbuffer-cleanups-v2 branch removes all the old swrast
>> GetRow/PutRow stuff. All swrast rendering is now done through
>> renderbuffer mapping and the format_pack/unpack.c code.
>
>
> Woo hoo!  Thanks for tackling this!  I've been slowly putting bandaids on
> some of the code, but it looks like you've saved me a ton of work!
>
>
>> The gl_renderbuffer type is smaller and cleaner now. Plus, a few more
>> old driver hooks are removed.
>
>
> I'm reviewing this code, and it looks good so far.  However, it looks like
> it won't build at every commit.  That's really important for bisecting.  For
> example, I notice the patch that adds uses of gl_renderbuffer::Map appear
> before the patch that adds the field.

Hmm, I'll have to check on that tomorrow.  I redid the whole patch
series today (hence -v2) and could have made a mistake along the way.

-Brian