[Mesa-dev] [PATCH] st/mesa: add fallback pipe formats for (compressed) R, RG formats

[Brian Paul]

On 01/19/2012 09:55 AM, Marek Olšák wrote:
> On Thu, Jan 19, 2012 at 4:54 PM, Brian Paul<brianp at vmware.com>  wrote:
>> If we don't find an exact PIPE_FORMAT_x for a GL_(COMPRESSED)_RED/RG format,
>> try uncompressed formats.  We were already doing this for the RGB(A) formats.
>>
>> Fixes piglit arb_texture_compression-internal-format-query test.
>>
>> NOTE: This is a candidate for the stable branches.
>> ---
>>   configs/default                    |    4 +++-
>>   configs/linux-dri                  |    3 ++-
>>   src/mesa/main/context.c            |   13 +++++++++++++
>>   src/mesa/main/texparam.c           |    4 ++++
>
> Hi Brian,
>
> I guess you didn't want to commit changes for the files above, did you?

No, Jose caught that too.


> Anyway, I agree that GL_COMPRESSED_RED and GL_COMPRESSED_RG should be
> able to fallback to a non-compressed format, but specifically adding
> fallbacks for RGTC1/2, LATC1/2, and 3DC is not any useful. If a driver
> doesn't expose the extensions for them, we shouldn't get them at all.
> I don't have a strong opinion about this, I just don't think it's a
> good idea to add fallbacks where they are not needed.

Well, I already pushed the patch.  When I get time I'd like to review 
the whole format mapping table.  I have a feeling there's other 
omissions and extraneous case.

Thanks.

-Brian