[Mesa-dev] [PATCH] Fix visibility of u_thread functions

[Jose Fonseca]

----- Original Message -----
> On Tue, Jan 24, 2012 at 2:41 AM, Brian Paul <brian.e.paul at gmail.com>
> wrote:
> > On Mon, Jan 23, 2012 at 12:48 PM, Matt Turner <mattst88 at gmail.com>
> > wrote:
> >> -fvisibility=hidden was preventing them from being exported, which
> >> combined with shared-glapi was causing undefined symbol errors at
> >> runtime.
> >> ---
> >> Brian: there might be more functions that should be exported. Let
> >> me know (or let me know what to test to find them) and I'll clean
> >> them up too.
> >>
> 
> [SNIP]
> 
> >
> > This looks good, and it's fine if you commit it, but I've still got
> > build problems:
> 
> Wait, something I want to be cleared up first, wont this export the
> u_tsd_* functions from libglapi library to the driver? And as such
> adding
> this to the support forever DRI driver ABI?
> 
> Cheers, Jakob.

There's also the risk of name collision -- if they are to be exposed to the application they should have an unique prefix.

But these functions are trivial, I think they should be inlined everywhere, so that dependent modules just link agains pthreads.

Jose