[Mesa-dev] [PATCH] Don't set defaults for gallium and dri drivers

[Kenneth Graunke]

On 01/24/2012 08:10 AM, Matt Turner wrote:
> On Tue, Jan 24, 2012 at 10:12 AM, Brian Paul<brian.e.paul at gmail.com>  wrote:
>> On Mon, Jan 23, 2012 at 12:48 PM, Matt Turner<mattst88 at gmail.com>  wrote:
>>> On Mon, Jan 23, 2012 at 9:28 AM, Jakob Bornecrantz<jakob at vmware.com>  wrote:
>>>> ----- Original Message -----
>>>>> If you're building mesa, you know what drivers you want.
>>>>
>>>> NACK, the default should be build as much as possible.
>>>
>>> We don't build OpenVG, OSMesa, i915g, GLESv1, GLESv2, and a number of
>>> Gallium state trackers by default.
>>>
>>> And while having reasonable defaults for components like EGL and GLES
>>> makes sense, having default drivers doesn't. I think we can roughly
>>> split people who build mesa into two groups:
>>> - developers&  users
>>> - distro packagers
>>>
>>> Developers and users are going to be building for a particular system
>>> with a single graphics card, so almost always they're going to have to
>>> disable either DRI or Gallium drivers. The current default doesn't
>>> work for them.
>>
>> As a developer (working in core Mesa a lot), I like to build all the
>> drivers all the time so that I don't accidentally break something
>> somewhere.  I don't think I'm the only one who should be doing that.
>> What configure options would you suggest in that case?
>
> --with-dri-drivers=i915,i965,radeon,r200,nouveau,swrast
> --with-gallium-drivers=r300,r600,i915,svga,swrast
>
> or it'd be easy to change configure to support --with-dri-drivers=all
> --with-gallium-drivers=all
>
>>> Distro packagers are either going to build everything they can, or
>>> offer knobs for users to select what they want to build. In the case
>>> of the former, they're not going to depend on our configure script to
>>> tell them what to build, because we already know it doesn't build
>>> everything.
>>>
>>> Neither group is served well by selecting a bunch of drivers when none
>>> are requested.
>>>
>>> I hope my reasoning is clear now.
>>>
>>>> The proper fix here is to merge --with-dri-drivers and
>>>> --with-gallium-drivers, and have it figure with gallium/dri
>>>> drivers to turn based on that list, so:
>>>>
>>>> --with-awesome-new-option=dri-vmwgfx,dri-i965
>>
>> Merging those options sounds good to me too.
>
> The more I've thought about it, the more I like this. I'll see what I can do.
>
> Matt

I do like the idea of having a single --with-drivers flag instead of 
--with-gallium-drivers and --with-dri-drivers.  Based on the driver 
name, it would do the right thing.

I think --enable-dri could/should be removed too, since it basically 
just lets you do bogus things like --disable-dri --with-dri-drivers=i965.

Which reminds me: can OSMesa and DRI drivers be built at the same time?