[Mesa-dev] [PATCH 2/2] i965/vs: Use the sampler for VS pull constant loading on Ivybridge.
kenneth at whitecape.org
Thu Jan 26 10:53:05 PST 2012
On 01/26/2012 09:03 AM, Eric Anholt wrote:
> On Thu, 26 Jan 2012 08:32:08 -0800, Kenneth Graunke<kenneth at whitecape.org> wrote:
>> Substantially increases performance in GLBenchmark PRO:
>> - 320x240 => 3.28x
>> - 1920x1080 => 1.47x
>> - 2560x1440 => 1.27x
>> The LD message ignores the sampler unit index and SAMPLER_STATE pointer,
>> instead relying on hard-wired default state. Thus, there's no need to
>> worry about running out of sampler units or providing SAMPLER_STATE;
>> this small patch should be all that's required.
> This looks much nicer than the previous patchset :)
> I do wonder about the args to ld, though. In 4x2 mode, it's "u v r
> lod". get_pull_constant_offset is filling .x with the dword offset, and
> .yzw are undefined. Is that what ld wants, or does it make use of v and
> r (.y and .z)?
I've spammed .x into .xyzw and everything worked, which suggests that it
really does ignore .yzw. So I think we should be fine.
More information about the mesa-dev