[Mesa-dev] [PATCH 4/9] automake: convert libmesa and libmesagallium

[Jon TURNEY]

On 09/07/2012 17:31, Eric Anholt wrote:
> Jon TURNEY <jon.turney at dronecode.org.uk> writes:
>> diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am
>> index bada760..08beaa6 100644
>> --- a/src/mesa/Makefile.am
>> +++ b/src/mesa/Makefile.am
> 
>> +libmesa_la_SOURCES = \
>> +	$(MESA_FILES) \
>> +	$(MESA_CXX_FILES) \
>> +        $(MESA_ASM_FILES_FOR_ARCH)
>> +
>> +libmesa_la_LIBADD = $(top_builddir)/src/glsl/libglsl.la
>> +libmesa_la_LDFLAGS = -static
> 
> Doesn't this -static result in relocations for static libs getting
> built, which would then be a problem for the linking into shared
> libraries later?  I don't really know this stuff well, but a -static in
> the middle of a shared lib build seems strange.
> 
> The helper lib for the asm code in libdricore built a .a file without
> -static being specified.

Yes, this is entirely wrong.  I think I added the '-static' when reading
'mklib -static' and never came back to change it to a convenience library.

> Also, with this commit, did you test that git_sha1 depencies were
> working correctly and commit --amending would produce a new sha1 in your
> drivers?

This appears to work for me.

I can see I have removed a dependency of depend: on git_sha1.h, but
recomputing the dependencies every time that file changes seems a bit of
overkill to me.  The computed dependencies still include git_sha1.h and things
which depend on it are rebuilt when it changes.