[Mesa-dev] [PATCH 1/5] i965/fs: Move a block out of a loop in live variables setup.

[Kenneth Graunke]

On 07/09/2012 03:40 PM, Eric Anholt wrote:
> This was accidentally copy-and-pasted inside.
> ---
>  src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp b/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp
> index 46408da..40e7ae5 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_live_variables.cpp
> @@ -192,11 +192,12 @@ fs_visitor::calculate_live_intervals()
>  
>  	    use[reg] = ip;
>  	 }
> -	 if (inst->dst.file == GRF) {
> -	    int reg = inst->dst.reg;
> +      }
>  
> -	    def[reg] = MIN2(def[reg], ip);
> -	 }
> +      if (inst->dst.file == GRF) {
> +         int reg = inst->dst.reg;
> +
> +         def[reg] = MIN2(def[reg], ip);
>        }
>  
>        ip++;

Patches 1-4 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(though I had comments on 3 and 4)

I'm still trying to work through patch 5.  It looks like some parts
aren't adding up, but I'm not sure whether that's a mistake in your code
or in my ability to read the patch.