[Mesa-dev] [PATCH] mesa, st/mesa: implement GL_RGB565 from ARB_ES2_compatibility

[Kenneth Graunke]

On 07/12/2012 11:12 AM, Marek Olšák wrote:
> On Thu, Jul 12, 2012 at 6:42 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> On 07/12/2012 05:25 AM, Marek Olšák wrote:
>>>
>>> This was not implemented, because the spec was changed just recently.
>>>
>>> Everything has been in place already.
>>>
>>> Gallium has PIPE_FORMAT_B5G6R5_UNORM, while Mesa has MESA_FORMAT_RGB565.
>>
>>
>> Oh wow, I didn't realize this was missing.  These changes look good to me.
>>
>> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>>
>> One question: should it be ctx->Extensions.ARB_ES2_compatibility || ctx->API
>> == API_OPENGLES2?  I suspect most drivers that support ES2 will also support
>> ARB_ES2_compatibility, so it shouldn't be a big deal in practice, but...
>
> Frankly, I'm not sure. I usually try to stay of out ES2 matters. I'll
> update the conditional as you say then.
>
> Marek

I just talked to Ian about this, and he seems to think 565 should be 
enabled if:

- ARB_ES2_compatibility is advertised
- API is ES 2
- API is ES 1 and the framebuffer object extension is enabled

That's a fairly complicated check that I hate to spam everywhere, so I 
might just leave it as you had it originally.  It won't be a problem for 
us since we always set the ARB_ES2_compatibility bit in the Intel drivers.

Either way.