[Mesa-dev] [PATCH 6/6] libgallium: Convert to automake

[Jon TURNEY]

On 13/07/2012 18:33, Tom Stellard wrote:
> +SUBDIRS += pipebuffer

This looks like an addition.  I'm not sure why, as the sources in pipebuffer/
are already listed in C_SOURCES?

> +
> +indices/u_indices_gen.c: indices/u_indices_gen.py
> +	$(PYTHON2) $< > $@

You might want to consider using $(AM_V_GEN) here

> +
> +indices/u_unfilled_gen.c: indices/u_unfilled_gen.py
> +	$(PYTHON2) $< > $@
> +
> +util/u_format_srgb.c: util/u_format_srgb.py
> +	$(PYTHON2) $< > $@
> +
> +util/u_format_table.c: util/u_format_table.py util/u_format_pack.py util/u_format_parse.py util/u_format.csv
> +	$(PYTHON2) util/u_format_table.py util/u_format.csv > $@
> +
> +#XXX: Delete this when all targets are converted to automake.
> +all-local: libgallium.la
> +	ln -f $(builddir)/.libs/libgallium.a $(builddir)/libgallium.a
> +
> +# DO NOT DELETE 

Go on, delete it, I dare you!