[Mesa-dev] [PATCH] glcpp: Pass through #line directives.

[Carl Worth]

Kenneth Graunke <kenneth at whitecape.org> writes:
> One bad thing about this patch is that it breaks 091-hash-line.c in glcpp's
> unit test suite.  I'm not sure what to do about that.  I could update the
> output, but the new output doesn't make much sense anymore...it gives you
> lovely messages like:
>
>     0:4(1): preprocessor error: #error line 25 error
>
> I also think we should add a test for #line with macro expansion.  Maybe
> something as simple as:
>
>     #define LINE_NUMBER 25
>     #define SOURCE_STRING_NUMBER 0
>     #line LINE_NUMBER SOURCE_STRING_NUMBER
>
> But I'm not sure whether to add that as 102, or replace 91.  Thoughts?

Thanks for raising these issues. Let me look at these and get back to
you before you push the patch.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120606/d00e6bc8/attachment.pgp>