[Mesa-dev] [PATCH 0/2] [RFC] r600g: improve handling of the shader exports

[Jerome Glisse]

On Tue, Jun 26, 2012 at 5:45 AM, Vadim Girlin <vadimgirlin at gmail.com> wrote:
> On Fri, 2012-06-22 at 14:24 -0400, Jerome Glisse wrote:
>> On Fri, Jun 22, 2012 at 10:02 AM, Vadim Girlin <vadimgirlin at gmail.com> wrote:
>> >  r600g: avoid unnecessary shader exports
>> >  r600g: enable DUAL_EXPORT mode when possible
>> >
>> > First patch fixes the lockups with DUAL_EXPORT mode for me, also AFAICS it
>> > fixes some depth/stencil tests, though I'm not sure why, haven't looked
>> > into it (possibly unexpected color exports were written over the depth
>> > exports).
>> >
>> > Second patch enables DUAL_EXPORT mode when possible, giving about 40%
>> > improvement with the results of the "fill" demo (on juniper). Also it sets
>> > DB_SOURCE_FORMAT to the EXPORT_DB_TWO when in DUAL_EXPORT mode, though I'm not sure yet if it has any effect on performance.
>> >
>> > I haven't tried to implement the same for pre-evergreen cards - I can't test it
>> > anyway without r600 hw, but I guess it shouldn't be hard. AFAIK there will be
>> > additional requirements for DUAL_EXPORT mode for r6xx (it's documented in the
>> > R6xx_3D_Registers.pdf).
>> >
>> > There are no regressions with piglit on evergreen (juniper).
>>
>> r6xx/r7xx version WIP not working (well not improving perf)
>> http://people.freedesktop.org/~glisse/0003-r600g-enable-DUAL_EXPORT-mode-when-possible-on-r6xx-.patch
>
> AFAIK you've fixed that already, do you have any regressions with dual
> export on r6xx/7xx? There are some issues reported on rv770 with patch 1
> - http://lists.freedesktop.org/archives/mesa-dev/2012-June/023229.html
>
> Vadim
>

Yeah i have updated patches here that fix regression. Will send
shortly once i am confident.

Cheers,
Jerome