[Mesa-dev] [PATCH 6/7] gallium: implement what's left for TIMESTAMP query

Brian Paul brianp at vmware.com
Wed Jun 27 07:39:35 PDT 2012


On 06/26/2012 07:50 PM, Marek Olšák wrote:
> ---
>   src/gallium/include/pipe/p_defines.h    |    3 ++-
>   src/mesa/state_tracker/st_cb_queryobj.c |    5 +++++
>   src/mesa/state_tracker/st_extensions.c  |    7 +++++++
>   3 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> index 479b26e..8d787ec 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -485,7 +485,8 @@ enum pipe_cap {
>      PIPE_CAP_USER_INDEX_BUFFERS = 69,
>      PIPE_CAP_USER_CONSTANT_BUFFERS = 70,
>      PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT = 71,
> -   PIPE_CAP_START_INSTANCE = 72
> +   PIPE_CAP_START_INSTANCE = 72,
> +   PIPE_CAP_QUERY_TIMESTAMP = 73

It would be nice if you'd add cases for PIPE_CAP_QUERY_TIMESTAMP in 
the softpipe, llvmpipe, svga drivers (to silence the new warnings 
about unhandled cases) but either you or I can do that in a follow-on 
patch.


Otherwise, the rest of the series looks good to me.

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list