[Mesa-dev] [PATCH] intel: Remove pointless software fallback for glBitmap on Gen6.

[Kenneth Graunke]

On 05/01/2012 04:41 PM, Chad Versace wrote:
> On 05/01/2012 03:53 PM, Kenneth Graunke wrote:
>> We already have a meta path below that works just fine; no apparent
>> regressions in oglconform.
>>
>> NOTE: This is a candidate for the 8.0 branch.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=46834
>> ---
>>   src/mesa/drivers/dri/intel/intel_pixel_bitmap.c |    4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c b/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c
>> index bdfb9ab..6821b69 100644
>> --- a/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c
>> +++ b/src/mesa/drivers/dri/intel/intel_pixel_bitmap.c
>> @@ -337,9 +337,5 @@ intelBitmap(struct gl_context * ctx,
>>                             unpack, pixels))
>>         return;
>>
>> -   /* FIXME */
>> -   if (intel->gen == 6)
>> -       return _swrast_Bitmap(ctx, x, y, width, height, unpack, pixels);
>> -
>>      _mesa_meta_Bitmap(ctx, x, y, width, height, unpack, pixels);
>>   }
>
> Approximately three months ago, disabling the fallback here caused a gpu
> hang in mesa-demos:src/samples/bitmap2.c, which uses *gasp* stencil bitmaps.
> I'm hoping your recent STC patch fixed the hang.
>
> As long as the hang no longer occurs with an up-to-date kernel,
> Reviewed-by: Chad Versace<chad.versace at linux.intel.com>

Yeah, I'm not sure what fixed it, but with modern components it works.

Thanks!