[Mesa-dev] [PATCH] i965/blorp: Move exec() out of brw_blorp_params.

Paul Berry stereotype441 at gmail.com
Tue May 15 07:31:48 PDT 2012


No functional change.  This patch replaces the
brw_blorp_params::exec() method with a global function
brw_blorp_exec() that performs the operation described by the params
data structure.
---
 src/mesa/drivers/dri/i965/brw_blorp.cpp      |    6 +++---
 src/mesa/drivers/dri/i965/brw_blorp.h        |    7 +++++--
 src/mesa/drivers/dri/i965/brw_blorp_blit.cpp |    2 +-
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_blorp.cpp b/src/mesa/drivers/dri/i965/brw_blorp.cpp
index 84f92b4..7e8e15c 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp.cpp
+++ b/src/mesa/drivers/dri/i965/brw_blorp.cpp
@@ -97,14 +97,14 @@ brw_blorp_params::brw_blorp_params()
 }
 
 void
-brw_blorp_params::exec(struct intel_context *intel) const
+brw_blorp_exec(struct intel_context *intel, const brw_blorp_params *params)
 {
    switch (intel->gen) {
    case 6:
-      gen6_blorp_exec(intel, this);
+      gen6_blorp_exec(intel, params);
       break;
    case 7:
-      gen7_blorp_exec(intel, this);
+      gen7_blorp_exec(intel, params);
       break;
    default:
       /* BLORP is not supported before Gen6. */
diff --git a/src/mesa/drivers/dri/i965/brw_blorp.h b/src/mesa/drivers/dri/i965/brw_blorp.h
index ebd11c4..ee27255 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp.h
+++ b/src/mesa/drivers/dri/i965/brw_blorp.h
@@ -153,8 +153,6 @@ public:
    virtual uint32_t get_wm_prog(struct brw_context *brw,
                                 brw_blorp_prog_data **prog_data) const = 0;
 
-   void exec(struct intel_context *intel) const;
-
    uint32_t x0;
    uint32_t y0;
    uint32_t x1;
@@ -169,6 +167,11 @@ public:
    brw_blorp_wm_push_constants wm_push_consts;
 };
 
+
+void
+brw_blorp_exec(struct intel_context *intel, const brw_blorp_params *params);
+
+
 /**
  * Parameters for a HiZ or depth resolve operation.
  *
diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
index 223d8c1..128414f 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
@@ -235,7 +235,7 @@ try_blorp_blit(struct intel_context *intel,
    brw_blorp_blit_params params(brw_context(ctx), src_mt, dst_mt,
                                 srcX0, srcY0, dstX0, dstY0, dstX1, dstY1,
                                 mirror_x, mirror_y);
-   params.exec(intel);
+   brw_blorp_exec(intel, &params);
 
    /* Mark the dst buffer as needing a HiZ resolve if necessary. */
    intel_renderbuffer_set_needs_hiz_resolve(dst_irb);
-- 
1.7.7.6



More information about the mesa-dev mailing list