[Mesa-dev] [PATCH v2 0/6] move software primitive restart into VBO module

[Kenneth Graunke]

On 05/13/2012 07:00 AM, Jordan Justen wrote:
> v2:
>   * change non-gallium drivers to not enable NV_primitive_restart
>     by default. (this matches the current mesa behavior.)
>   * gallium drivers will continue to use software primitivie restart
>     where needed and will always declare the NV_primitive_restart
>     extension. (this matches the current mesa behavior.)
>   * renamed vbo_exec_array.c:vbo_exec_array_draw_prims to
>     vbo_handle_primitive_restart
>   * only call vbo_handle_primitive_restart in the required cases
>
> v1:
>   * move software primitive restart from mesa/state_tracker/st_draw.c
>     into src/mesa/vbo/vbo_primitive_restart.c
>   * if the gallium PIPE_CAP_PRIMITIVE_RESTART param is set, then
>     the VBO software primitive restart support is disabled
>   * enable the NV_primitive_restart extension by default
>   * tested with i965 and llvmpipe (PIPE_CAP_PRIMITIVE_RESTART
>     manually removed)
>
> Jordan Justen (6):
>    vbo: add software primitive restart support
>    mesa: add PrimitiveRestartInSoftware to gl_context.Const
>    vbo: use software primitive restart in the VBO module
>    state_tracker: set PrimitiveRestartInSoftware if needed
>    state_tracker: remove software handling of primitive restart
>    state_tracker: remove sw_primitive_restart from st_context
>
>   src/mesa/SConscript                    |    1 +
>   src/mesa/main/context.c                |    3 +
>   src/mesa/main/mtypes.h                 |    5 +
>   src/mesa/sources.mak                   |    1 +
>   src/mesa/state_tracker/st_context.h    |    1 -
>   src/mesa/state_tracker/st_draw.c       |  180 +------------------------
>   src/mesa/state_tracker/st_extensions.c |    2 +-
>   src/mesa/vbo/vbo.h                     |    5 +
>   src/mesa/vbo/vbo_exec_array.c          |   35 ++++-
>   src/mesa/vbo/vbo_primitive_restart.c   |  225 ++++++++++++++++++++++++++++++++
>   10 files changed, 272 insertions(+), 186 deletions(-)
>   create mode 100644 src/mesa/vbo/vbo_primitive_restart.c
>

Patches 1-3 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Patches 4-6 seem fine to me too, but I've never looked at the Gallium 
code there.  I'm not planning on reviewing them in detail.