[Mesa-dev] [PATCH] mesa: Remove the generated glapi from source control, and just build it.

[Ian Romanick]

On 05/23/2012 12:45 PM, Eric Anholt wrote:
> Mesa already always depends on python to build.  The checked in
> changes are not reviewed (because any trivial change rewrites the
> world).  We also have been pushing commits between xml change and
> regen where at-build-time xml-generated code disagrees with committed
> xml-generated code.  And worst of all, sometimes we ("I") check in
> *stale* xml-generated code.
> ---
>
> I dropped the giant file removals from the diff output to fit on the
> mailing list.
>
> This doesn't fix the make clean requirement in Mesa, because
> makedepend appears to be just plain broken.  However, my upcoming
> automake series does fix it by not using makedepend.  Modifying glapi
> and typing "make", woo!

I'm not going to block these changes from landing.

I'm putting together a branch with a big pile of unit tests that I think 
should catch most of catastrophic cases that I'm worried about.  I 
already have tests that verify

   src/glx/indirect_init.c
   src/glx/indirect_size.c
   src/mapi/glapi/glapitable.h
   src/mapi/glapi/glprocs.h
   src/mesa/main/enums.c

I even found some (really minor) bugs along the way.

The main things left that worry me are src/glx/indirect.c and the 
various generated assembly files.  indirect.c is a pain in the ass for 
unit tests.  As soon as you link with it, it has to pull in glxcmds.c 
and glxext.c, and the world explodes.