[Mesa-dev] [PATCH 2/2] mesa: glsl: allow ES2 to report support for GLSL versions >= 1.20

Ian Romanick idr at freedesktop.org
Fri May 25 15:14:32 PDT 2012


On 05/25/2012 01:13 PM, Eric Anholt wrote:
> On Fri, 25 May 2012 16:16:30 +0300, Oliver McFadden<oliver.mcfadden at linux.intel.com>  wrote:
>> This bug was discovered while running the Khronos conformance test suite
>> on i965 classic driver and receiving "implementation error: meta program
>> compile failed."
>>
>> This bug was recently introduced by the i965 clear patch set and would
>> not be visible while using the GL API (only ES2 API) and only on gen6+
>> hardware (which claims support for GLSL 1.30)
>>
>> Signed-off-by: Oliver McFadden<oliver.mcfadden at linux.intel.com>
>
> I don't think we should do this -- aren't you letting someone do
> #version 130 in their ES2 context?
>
> In the past, for "let core Mesa do desktop GL things in an ES context",
> we've put some flag in place across linking.  But in this case, I think
> the right answer is to just have a separate shader string in the meta
> code for the ES2 case.

Do we even need that?  It looks like the shader uses 'out' so that it 
can have an ivec4 output for clearing an integer render target.  We 
don't have those in ES2 contexts.  Right?


More information about the mesa-dev mailing list