[Mesa-dev] [PATCH 10/13] clover: Remove target argument from compile_program_tgsi()

Francisco Jerez currojerez at riseup.net
Sun May 27 05:26:32 PDT 2012


tstellar at gmail.com writes:

> From: Tom Stellard <thomas.stellard at amd.com>
>
> ---
>  .../state_trackers/clover/core/compiler.hpp        |    3 +--
>  src/gallium/state_trackers/clover/core/program.cpp |    2 +-
>  .../state_trackers/clover/tgsi/compiler.cpp        |    3 +--
>  3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/state_trackers/clover/core/compiler.hpp b/src/gallium/state_trackers/clover/core/compiler.hpp
> index a3998d5..686c7d8 100644
> --- a/src/gallium/state_trackers/clover/core/compiler.hpp
> +++ b/src/gallium/state_trackers/clover/core/compiler.hpp
> @@ -46,8 +46,7 @@ namespace clover {
>     module compile_program_llvm(const compat::string &source,
>                                 const compat::string &target);
>  
> -   module compile_program_tgsi(const compat::string &source,
> -                               const compat::string &target);
> +   module compile_program_tgsi(const compat::string &source);
>  }
>  
>  #endif
> diff --git a/src/gallium/state_trackers/clover/core/program.cpp b/src/gallium/state_trackers/clover/core/program.cpp
> index 5ac9f93..06ac2af 100644
> --- a/src/gallium/state_trackers/clover/core/program.cpp
> +++ b/src/gallium/state_trackers/clover/core/program.cpp
> @@ -48,7 +48,7 @@ _cl_program::build(const std::vector<clover::device *> &devs) {
>     for (auto dev : devs) {
>        try {
>           auto module = (dev->ir_target() == "tgsi" ?
> -                        compile_program_tgsi(__source, dev->ir_target()) :
> +                        compile_program_tgsi(__source) :
>                          compile_program_llvm(__source, dev->ir_target()));
>           __binaries.insert({ dev, module });
>  
> diff --git a/src/gallium/state_trackers/clover/tgsi/compiler.cpp b/src/gallium/state_trackers/clover/tgsi/compiler.cpp
> index eb27db1..a6c7fa3 100644
> --- a/src/gallium/state_trackers/clover/tgsi/compiler.cpp
> +++ b/src/gallium/state_trackers/clover/tgsi/compiler.cpp
> @@ -88,8 +88,7 @@ namespace {
>  }
>  
>  module
> -clover::compile_program_tgsi(const compat::string &source,
> -                             const compat::string &target) {
> +clover::compile_program_tgsi(const compat::string &source) {
>     const char *body = source.find("COMP\n");
>     module m;

Reviewed-by: Francisco Jerez <currojerez at riseup.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120527/94bbc199/attachment.pgp>


More information about the mesa-dev mailing list