[Mesa-dev] [PATCH 25/26] glapi: Remove GL_NV_fence from the dispatch table

Ian Romanick idr at freedesktop.org
Tue May 29 15:51:52 PDT 2012


From: Ian Romanick <ian.d.romanick at intel.com>

There is no GLX protocol for these functions.  No open-source Linux
driver has ever supported this extension, and it seems unlikely at
this point that one ever will.  There's no reason to have slots for
these functions in the dispatch table.

The unit test is also updated.  The odd side effect here is the test
GetProcAddress::TableAsBigAsAt_git_b45052b now really has nothing to
do with GIT SHA1 b45052b.  This is why the new value is '978u - 7u'.
GIT SHA1 b45052b had 978 entries, and seven are removed by this
change.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 src/mapi/glapi/gen/gl_API.xml        |   14 +++++++-------
 src/mapi/glapi/tests/check_table.cpp |   12 ++++--------
 2 files changed, 11 insertions(+), 15 deletions(-)

diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
index bd75105..aef4d82 100644
--- a/src/mapi/glapi/gen/gl_API.xml
+++ b/src/mapi/glapi/gen/gl_API.xml
@@ -11005,43 +11005,43 @@
 </category>
 
 <category name="GL_NV_fence" number="222">
-    <function name="DeleteFencesNV" offset="assign" static_dispatch="false">
+    <function name="DeleteFencesNV">
         <param name="n" type="GLsizei"/>
         <param name="fences" type="const GLuint *"/>
         <glx ignore="true"/>
     </function>
 
-    <function name="GenFencesNV" offset="assign" static_dispatch="false">
+    <function name="GenFencesNV">
         <param name="n" type="GLsizei" counter="true"/>
         <param name="fences" type="GLuint *" output="true" count="n"/>
         <glx ignore="true"/>
     </function>
 
-    <function name="IsFenceNV" offset="assign" static_dispatch="false">
+    <function name="IsFenceNV">
         <param name="fence" type="GLuint"/>
         <return type="GLboolean"/>
         <glx ignore="true"/>
     </function>
 
-    <function name="TestFenceNV" offset="assign" static_dispatch="false">
+    <function name="TestFenceNV">
         <param name="fence" type="GLuint"/>
         <return type="GLboolean"/>
         <glx ignore="true"/>
     </function>
 
-    <function name="GetFenceivNV" offset="assign" static_dispatch="false">
+    <function name="GetFenceivNV">
         <param name="fence" type="GLuint"/>
         <param name="pname" type="GLenum"/>
         <param name="params" type="GLint *" output="true"/>
         <glx ignore="true"/>
     </function>
 
-    <function name="FinishFenceNV" offset="assign" static_dispatch="false">
+    <function name="FinishFenceNV">
         <param name="fence" type="GLuint"/>
         <glx ignore="true"/>
     </function>
 
-    <function name="SetFenceNV" offset="assign" static_dispatch="false">
+    <function name="SetFenceNV">
         <param name="fence" type="GLuint"/>
         <param name="condition" type="GLenum"/>
         <glx ignore="true"/>
diff --git a/src/mapi/glapi/tests/check_table.cpp b/src/mapi/glapi/tests/check_table.cpp
index db2b583..0073d70 100644
--- a/src/mapi/glapi/tests/check_table.cpp
+++ b/src/mapi/glapi/tests/check_table.cpp
@@ -88,8 +88,11 @@ TEST(GetProcAddress, TableAsBigAsAt_git_b45052b)
     *
     * 13 entries were removed when GL_NV_register_combiners was removed from
     * the dispatch table.
+    *
+    * 7 entries were removed when GL_NV_fence was removed from the dispatch
+    * table.
     */
-   EXPECT_GE(table_entries, 978u - 6u - 1u - 2u - 13u);
+   EXPECT_GE(table_entries, 978u - 6u - 1u - 2u - 13u - 7u);
 }
 
 TEST(GetProcAddress, QueriedDispatchSizeBigEnough)
@@ -1315,13 +1318,6 @@ const struct name_offset known_dispatch[] = {
    { "glWindowPos4svMESA", _O(WindowPos4svMESA) },
    { "glMultiModeDrawArraysIBM", _O(MultiModeDrawArraysIBM) },
    { "glMultiModeDrawElementsIBM", _O(MultiModeDrawElementsIBM) },
-   { "glDeleteFencesNV", _O(DeleteFencesNV) },
-   { "glFinishFenceNV", _O(FinishFenceNV) },
-   { "glGenFencesNV", _O(GenFencesNV) },
-   { "glGetFenceivNV", _O(GetFenceivNV) },
-   { "glIsFenceNV", _O(IsFenceNV) },
-   { "glSetFenceNV", _O(SetFenceNV) },
-   { "glTestFenceNV", _O(TestFenceNV) },
    { "glAreProgramsResidentNV", _O(AreProgramsResidentNV) },
    { "glBindProgramNV", _O(BindProgramNV) },
    { "glDeleteProgramsNV", _O(DeleteProgramsNV) },
-- 
1.7.6.5



More information about the mesa-dev mailing list